Drop BasecampAgent

This was written in the Basecamp Classic age and its authentication has been seemingly broken since the introduction of Basecamp 2 or 3.

Author: knu

Gemfile

@@ -81,9 +81,6 @@ gem 'aws-sdk-core', '~> 2.2.15'
 gem 'omniauth-google-oauth2', '>= 0.8.0'
 gem 'gmail_xoauth' # support for Gmail using OAuth
 
-# Optional Services.
-gem 'omniauth-37signals'          # BasecampAgent
-
 # Bundler <1.5 does not recognize :x64_mingw as a valid platform name.
 # Unfortunately, it can't self-update because it errors when encountering :x64_mingw.
 unless Gem::Version.new(Bundler::VERSION) >= Gem::Version.new('1.5.0')

Gemfile.lock

@@ -479,9 +479,6 @@ GEM
     omniauth (1.9.1)
       hashie (>= 3.4.6)
       rack (>= 1.6.2, < 3)
-    omniauth-37signals (1.0.5)
-      omniauth (~> 1.0)
-      omniauth-oauth2 (~> 1.0)
     omniauth-evernote (1.2.1)
       evernote-thrift
       multi_json (~> 1.0)
@@ -786,7 +783,6 @@ DEPENDENCIES
   net-ftp-list (~> 3.2.8)
   nokogiri (>= 1.10.8)
   omniauth
-  omniauth-37signals
   omniauth-dropbox-oauth2!
   omniauth-evernote
   omniauth-google-oauth2 (>= 0.8.0)

README.md

@@ -15,7 +15,7 @@ Huginn is a system for building agents that perform automated tasks for you onli
 * Watch for air travel or shopping deals
 * Follow your project names on Twitter and get updates when people mention them
 * Scrape websites and receive email when they change
-* Connect to Adioso, HipChat, Basecamp, Growl, FTP, IMAP, Jabber, JIRA, MQTT, nextbus, Pushbullet, Pushover, RSS, Bash, Slack, StubHub, translation APIs, Twilio, Twitter, Wunderground, and Weibo, to name a few.
+* Connect to Adioso, HipChat, Growl, FTP, IMAP, Jabber, JIRA, MQTT, nextbus, Pushbullet, Pushover, RSS, Bash, Slack, StubHub, translation APIs, Twilio, Twitter, and Weibo, to name a few.
 * Send digest email with things that you care about at specific times during the day
 * Track counts of high frequency events and send an SMS within moments when they spike, such as the term "san francisco emergency"
 * Send and receive WebHooks

app/assets/stylesheets/application.scss.erb

@@ -276,7 +276,6 @@ h2 .scenario, a span.label.scenario {
 
 $service-colors: (
   twitter:      #55acee,
-  37signals:    #8fc857,
   github:       #444444,
   tumblr:       #2c4762,
   dropbox:      #007EE5,

app/controllers/application_controller.rb

@@ -29,7 +29,6 @@ def authenticate_admin!
   def upgrade_warning
     return unless current_user
     twitter_oauth_check
-    basecamp_auth_check
     outdated_google_auth_check
   end
 
@@ -58,12 +57,6 @@ def twitter_oauth_check
     end
   end
 
-  def basecamp_auth_check
-    unless Devise.omniauth_providers.include?(:'37signals')
-      @basecamp_agent = current_user.agents.where(type: 'Agents::BasecampAgent').first
-    end
-  end
-
   def outdated_google_auth_check
     @outdated_google_cal_agents = current_user.agents.of_type('Agents::GoogleCalendarPublishAgent').select do |agent|
       agent.options['google']['key_secret'].present?

app/models/agents/basecamp_agent.rb

@@ -32,24 +32,12 @@ def prepare_request
   end
 
   def refresh_token_parameters
-    case provider
-    when  '37signals'
-      {
-        type:          'refresh',
-        client_id:     oauth_key,
-        client_secret: oauth_secret,
-        refresh_token: refresh_token
-      }
-    else
-      # Paramters required by standard compliant OAuth2 providers,
-      # including Google
-      {
-        grant_type: 'refresh_token',
-        client_id:     oauth_key,
-        client_secret: oauth_secret,
-        refresh_token: refresh_token
-      }
-    end
+    {
+      grant_type: 'refresh_token',
+      client_id:     oauth_key,
+      client_secret: oauth_secret,
+      refresh_token: refresh_token
+    }
   end
 
   def refresh_token!
@@ -100,10 +88,6 @@ def self.get_options(omniauth)
     {name: omniauth['info']['nickname'] || omniauth['info']['name']}
   end
 
-  register_options_provider('37signals') do |omniauth|
-    {user_id: omniauth['extra']['accounts'][0]['id'], name: omniauth['info']['name']}
-  end
-
   register_options_provider('google') do |omniauth|
     {
       email: omniauth['info']['email'],

app/models/service.rb

@@ -1,4 +1,4 @@
-<% if @twitter_agent || @basecamp_agent %>
+<% if @twitter_agent %>
   <div class="alert alert-danger" role="alert">
     <p>
       <b>Warning!</b> You need to update your Huginn configuration, so your agents continue to work with the new OAuth services.
@@ -16,12 +16,6 @@ TWITTER_OAUTH_SECRET=<%= @twitter_oauth_secret %>
 
       </p>
     <% end %>
-    <% if @basecamp_agent %>
-      <p>
-        Your <b>Basecamp</b> agents could not be migrated automatically. You need to manually register an application with 37signals and authenticate Huginn to use it.<br/>
-        Have a look at the <%= link_to 'Wiki', 'https://github.com/huginn/huginn/wiki/Configuring-OAuth-applications', target: '_blank' %> if you need help.
-      </p>
-    <% end %>
   </div>
 <% end -%>
 <% if @outdated_google_cal_agents && @outdated_google_cal_agents.length > 0 %>

app/views/application/_upgrade_warning.html.erb

@@ -247,12 +247,6 @@
     config.omniauth :'tumblr', key, secret
   end
 
-  if defined?(OmniAuth::Strategies::ThirtySevenSignals) &&
-     (key = ENV["THIRTY_SEVEN_SIGNALS_OAUTH_KEY"]).present? &&
-     (secret = ENV["THIRTY_SEVEN_SIGNALS_OAUTH_SECRET"]).present?
-    config.omniauth :'37signals', key, secret
-  end
-
   if defined?(OmniAuth::Strategies::DropboxOauth2) &&
      (key = ENV["DROPBOX_OAUTH_KEY"]).present? &&
      (secret = ENV["DROPBOX_OAUTH_SECRET"]).present?

config/initializers/devise.rb

@@ -30,7 +30,6 @@ en:
       twitter: "Twitter"
       tumblr: "Tumblr"
       github: "GitHub"
-      37signals: "37Signals (Basecamp)"
       dropbox: "Dropbox"
       dropbox_oauth2: "Dropbox"
       evernote: "Evernote"