Commit c97a9d1
committed
LOC-7325: make the LocalBinary Download tests actually run
The three Download tests could never pass. `binary.key` was never set,
though binaryPath() sets it before every real download() call, so the
source-url fetch was rejected with "Invalid auth token". `retries` was
omitted too, making the retry check `undefined > 0` — every failure went
straight to the terminal branch with no retry.
On master this block hangs rather than fails, because the terminal path
there never invokes the callback; that defect was fixed earlier in this
branch, which turned the hang into a fast assertion failure and made the
real cause visible.
With the key supplied the block passes for the first time, covering the
real HTTP download end to end — direct and through a proxy, async and
sync — which is what exercises the new non-200 response check against a
live source.
Verified with real credentials: full suite 59 passing, 1 failing. The one
failure (`should stop local`) fails identically on origin/master.1 parent 69bd942 commit c97a9d1
1 file changed
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
454 | 458 | | |
455 | 459 | | |
456 | 460 | | |
| |||
465 | 469 | | |
466 | 470 | | |
467 | 471 | | |
468 | | - | |
| 472 | + | |
469 | 473 | | |
470 | 474 | | |
471 | 475 | | |
| |||
479 | 483 | | |
480 | 484 | | |
481 | 485 | | |
482 | | - | |
| 486 | + | |
483 | 487 | | |
484 | 488 | | |
485 | 489 | | |
486 | 490 | | |
487 | 491 | | |
488 | | - | |
| 492 | + | |
489 | 493 | | |
490 | 494 | | |
491 | 495 | | |
| |||
0 commit comments