Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict between asciinema and aws_cli packages #219

Open
kylewlacy opened this issue Jan 29, 2025 · 2 comments
Open

Fix conflict between asciinema and aws_cli packages #219

kylewlacy opened this issue Jan 29, 2025 · 2 comments

Comments

@kylewlacy
Copy link
Member

If you run brioche install -r asciinema and brioche install -r aws_cli, the two packages will interfere with each other. This is because both packages write a Python virtual environment1 to venv, so they will compete for which version of Python should be used.

A simple fix we can do on the packaging side is to make it so they each use a different folder for their venvs. This should be a simple, low-cost fix that wouldn't require any changes on the Brioche side.

Footnotes

  1. They don't technically use Python venvs, but rather venv is basically a portable Python install prefix, which walks like a venv and quacks like a venv. They're nearly indistinguishable from actual Python venvs.

@adminy
Copy link

adminy commented Feb 10, 2025

Shouldn't they also be using specific python version to keep it pure and adhere to individual projects featuresets?

@kylewlacy
Copy link
Member Author

Shouldn't they also be using specific python version to keep it pure and adhere to individual projects featuresets?

Yep, that's the goal! If you were to run brioche run -r asciinema and brioche run -r aws_cli, they would each use their own version of Python-- each has a venv directory, which includes a full, independent Python installation.

It's a quirk of brioche install that it puts installed packages into one big shared installation directory, meaning that the two venv directories would fight each other. Say you install asciinema first, followed by aws_cli: aws_cli's venv dir would overwrite (part of) asciinema's venv, which includes the main bin/python executable.

So, once this issue is resolved, they would use separate paths for their instances of Python, so each could use its own independent Python version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants