Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This plugin stopped working because of changes made by maxmind #4

Open
MartinMystikJonas opened this issue Jan 9, 2020 · 4 comments · May be fixed by #5
Open

This plugin stopped working because of changes made by maxmind #4

MartinMystikJonas opened this issue Jan 9, 2020 · 4 comments · May be fixed by #5

Comments

@MartinMystikJonas
Copy link

https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/

@MartinMystikJonas
Copy link
Author

Download URL should be updated to https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-Country&license_key=[LICENSE_KEY]&suffix=tar.gz and there should be way to provide end user license key - I believe Composer has section '''extra''' in composer.json for this. Users have to create maxmind account and generate their license key.

@schlessera
Copy link
Member

I think we'd need to go with an environment variable instead of the "extra" section in the Composer file, though.

Otherwise, that would lead to trouble where people publically commit their keys and other people reuse them.

@kozie
Copy link

kozie commented Mar 2, 2020

@schlessera are there any plans on updating this module according to the new download method? Thanks in advance

@kozie
Copy link

kozie commented Mar 4, 2020

I added a PR (see #5) which updates the module to work with the new method by MaxMind. I implemented using the root composer.json as this seemed to work for me (knowing the downsides of course) but it should be fairly easy to add other ways of passing the license by (for example) environment variables.

@kozie kozie linked a pull request Mar 4, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants