Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always returns United States #7

Open
dejagersh opened this issue Jan 28, 2019 · 6 comments
Open

Always returns United States #7

dejagersh opened this issue Jan 28, 2019 · 6 comments

Comments

@dejagersh
Copy link

image

@GaryJones
Copy link
Contributor

Did the local database file get created?

@dejagersh
Copy link
Author

Not sure and can't check anymore. I had to replace it.

I can't reproduce it in a fresh project. It works fine, until I remove the database file. So I guess something went wrong in creating the local database file. Maybe our firewall that's running in Production is blocking the download.

@GaryJones
Copy link
Contributor

I guess some defensive code could be added here for failed downloading, plus not having curl available, etc.

@NeilJ247
Copy link

NeilJ247 commented Nov 16, 2020

Hi,

I am seeing the same issue. We use docker for both local dev and production. It is only production in which I can see this happening. We use AWS Fargate. Not investigated it any further at the moment.

Edit: I actually see what the issue is in my case. For production images we remove curl to reduce the image size. As the file is not downloaded it defaults to fallback US.

@schlessera
Copy link
Member

I was planning to revsit this for Composer v2 compact checking. I'll investigate whether I can reuse Composer's download mechanism, as that is probably more robust.

@NeilJ247
Copy link

Just to add there is another issue when using Docker. If you don't have write permissions to the vendor path it will also fail to download the CSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants