Upgrade to videojs 5

[doublex]

Are there any plans to upgrade this great plugin to videojs 5?

[iraniamir]

its not working on 5.4.4

[tahola]

Yes, not working on 5.4.4, the seconds doenst match.

[gkatsev]

Yeah, this needs to get updated to videojs. Anyone want to take a crack at it? See https://github.com/videojs/video.js/wiki/5.0-Change-Details for the changes.

[tahola]

For anyonye interested, changing this line

mouseTime = Math.floor((left - progressControl.el().offsetLeft) / progressControl.width() * duration);

by

mouseTime = Math.floor(event.offsetX / progressControl.width() * duration);

worked for me.

[iraniamir]

On 5.4.5 says : Uncaught TypeError: Cannot read property 'progressControl' of undefined

progressControl = player.controlBar.progressControl;

[cryptiklemur]

Same issue that @tavousi has, here

[xbgmsharp]

Works for me using.
http://docs.brightcove.com/en/video-cloud/brightcove-player/guides/thumbnails-plugin.html

[ali-idrizi]

For Video.js 5, in videojs.thumbnails.js I replaced this line:

mouseTime = Math.floor((left - progressControl.el().offsetLeft) / progressControl.width() * duration);

with this

var mouseTimeHMS  = $(".vjs-mouse-display").attr("data-current-time").split(":");
var mouseTime = 0;
for(var i = mouseTimeHMS.length - 1; i >= 0; i--)
    mouseTime += parseInt((i == mouseTimeHMS.length-1) ? (mouseTimeHMS[i]) : ((i == mouseTimeHMS.length-2) ? (mouseTimeHMS[i] * 60) : ((i == mouseTimeHMS.length-3) ? (mouseTimeHMS[i] * 60 * 60) : (0))));

And it is working perfectly in any way now.

[ghost]

@iraniamir about the

Uncaught TypeError: Cannot read property 'progressControl' of undefined

in my case me the error triggers if I init the player and add the plugin within the same statement

var player = videojs("video", {
    plugins: {
        thumbnails: {
            // plugin settings here
        }
 });

but doesn't if I separate the player initialization from the plugin's one

player = videojs("myVideojsId");

player.thumbnails({
    // plugin settings
});

I'm using videojs 5.13.2 minified version.

[bernardoadc]

Thanks @mrcointreau , the same worked here, using player.options.children

[trisys3]

By now, you would need to be compatible with VideoJS 6-7, as well. To be clear, I'm not sure if adding compatibility with 5 won't automatically add compatibility with 6-7, just putting it out there.