Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNSName claims it doesn't implement Eq and PartialEq, yet it does #78

Open
8573 opened this issue Sep 20, 2018 · 2 comments
Open

DNSName claims it doesn't implement Eq and PartialEq, yet it does #78

8573 opened this issue Sep 20, 2018 · 2 comments

Comments

@8573
Copy link

8573 commented Sep 20, 2018

The documentation for DNSName claims that—

Eq, PartialEq, etc. are not implemented because name comparison frequently should be done case-insensitively and/or with other caveats that depend on the specific circumstances in which the comparison is done.

—and yet, the "Trait Implementations" section of that documentation lists implementations of these very traits.
@briansmith
Copy link
Owner

I have started addressing this in #125. PTAL.

@8573
Copy link
Author

8573 commented Mar 23, 2020

PTAL.

I'm afraid I can't give an informed opinion on the merits of implementing these traits despite the "other caveats" (as I'm not familiar enough with DNS to know what those are), but I've commented on a couple of minor things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briansmith @8573