Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for RISCV32 #2041

Closed
ub-tech opened this issue Apr 30, 2024 · 4 comments
Closed

support for RISCV32 #2041

ub-tech opened this issue Apr 30, 2024 · 4 comments
Milestone

Comments

@ub-tech
Copy link

ub-tech commented Apr 30, 2024

Hi - I'm trying to run a repo with ring as dependency on a RISC32 arch. I tried to override the dependency based on this convo. Is riscv32 supported? Am I trying to implement this override correctly (please see below)? TY very much for any insights.

[patch.crates-io]
ring = { git = "https://github.com/leso-kn/ring.git", package = "ring", branch = "riscv64-support-plus-riscv32" }

@ub-tech ub-tech changed the title support for RISC32 support for RISCV32 Apr 30, 2024
@briansmith
Copy link
Owner

In target.h, we have:

#elif defined(__riscv) && __SIZEOF_POINTER__ == 8
#define OPENSSL_64_BIT

So presumably we would also need to add the corresponding change for riscv32.

The bigger issue, AFAICT, is that we don't have any way of testing riscv32 code in CI.

@briansmith
Copy link
Owner

See #2042 (comment) for an alternative approach.

@briansmith
Copy link
Owner

Please check out PR #2082 to see if this works for you.

@briansmith
Copy link
Owner

Closing this on the assumption that PR #2082 resolves this, at least if you're not using an old version of GCC>

@briansmith briansmith added this to the 0.17.9 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants