Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No embeddings/links created for new notes #927

Open
l-mb opened this issue Dec 17, 2024 · 5 comments
Open

No embeddings/links created for new notes #927

l-mb opened this issue Dec 17, 2024 · 5 comments

Comments

@l-mb
Copy link

l-mb commented Dec 17, 2024

I have Smart Connections 2.3.45 on Obsidian 1.7.7 on a Linux desktop.

I use OpenAI Text-3 Large as the embedding model (minimum embedding length set to 100).

It works fine after initial setup, but eventually, new/updated notes don't seem to be indexed/embedded, and going to the notes would show a No entity found for key: <pathname> notification.

Instead, the smart links tab would keep showing the results of the previous notes (I think at least the tab should be cleared if the file isn't embedded right?).

Re-load Sources, Import etc all don't fix it; "Clear All & Re-import" does, but is obviously kind of a big hammer :-)

My expectation would be that embeddings are asynchronously updated/created for updated/new notes?

Suggestion

Not sure if there's a grace/dampening period anywhere, obviously we also wouldn't want it to happen after every key press - maybe after xx minutes of inactivity, and/or with an explicit "Refresh embedding" trigger command, and in the mean time show that it's a wee bit outdated?

@brianpetro
Copy link
Owner

@l-mb this is something I've been thinking about and do plan on implementing.

In the meantime, the Refresh and make connections command will trigger the re-embedding of the current note.

Local models running in Obsidian are the current bottleneck, since embedding often slows down Obsidian significantly. However, this is a non-issue with API/cloud models.

Thanks for raising the issue 🌴

@l-mb
Copy link
Author

l-mb commented Dec 20, 2024

Thanks for the response!

There is no "Refresh and make connections" command in my Obsidian command - I assume you mean the "Refresh" button in the sidebar? That seems to do exactly nothing for me (and never really has, as far as I could tell, not even a failure notification).

@brianpetro
Copy link
Owner

@l-mb Refresh & make connections like this

image

🌴

@l-mb
Copy link
Author

l-mb commented Dec 21, 2024

Ohhh. I was typing a literal "Refresh and" into the command palette and it's an & ... My bad. Thanks. Yes, that works!

Though maybe that is a function that the refresh icon in the "Smart Connections" pane also could invoke?

@brianpetro
Copy link
Owner

Yes, I had a feeling that was it. Sorry for the confusion.

Though maybe that is a function that the refresh icon in the "Smart Connections" pane also could invoke?

Agreed. I made a note
image
🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants