Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep: fix logic for empty patterns #826

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Commits on Nov 19, 2024

  1. grep: fix logic for empty patterns

    * Checking length of $pattern is unreliable because it is valid for a pattern to have zero-length (meaning match-all)
    * I found this when testing the -f option but the logic applies to other usages of grep
    
    %md5sum a.c
    c9fd7ff4cb5b01981a2a362f82f44c89  a.c
    %perl grep -F '' a.c | md5sum 
    c9fd7ff4cb5b01981a2a362f82f44c89  -
    %printf "\n" > pat0 && perl grep -f pat0 a.c | md5sum 
    c9fd7ff4cb5b01981a2a362f82f44c89  -
    %perl grep -e '' a.c | md5sum 
    c9fd7ff4cb5b01981a2a362f82f44c89  -
    mknos authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    4ee1236 View commit details
    Browse the repository at this point in the history