-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grep: fix logic for empty patterns #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Nov 19, 2024
- Checking length of $pattern is unreliable because it is valid for a pattern to have zero-length (meaning match-all)
- I found this when testing the -f option but the logic applies to other usages of grep
* Checking length of $pattern is unreliable because it is valid for a pattern to have zero-length (meaning match-all) * I found this when testing the -f option but the logic applies to other usages of grep %md5sum a.c c9fd7ff4cb5b01981a2a362f82f44c89 a.c %perl grep -F '' a.c | md5sum c9fd7ff4cb5b01981a2a362f82f44c89 - %printf "\n" > pat0 && perl grep -f pat0 a.c | md5sum c9fd7ff4cb5b01981a2a362f82f44c89 - %perl grep -e '' a.c | md5sum c9fd7ff4cb5b01981a2a362f82f44c89 -
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
github-actions
bot
added
the
Type: enhancement
improve a feature that already exists
label
Nov 19, 2024
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
github-actions
bot
added
Priority: low
get to this whenever
Program: grep
The grep program
labels
Nov 19, 2024
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:28
— with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
November 19, 2024 13:29
— with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 11914073920Details
💛 - Coveralls |
briandfoy
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: grep
The grep program
Status: accepted
The fix is accepted
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.