Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: replace -1 with -m NUM #809

Merged
merged 1 commit into from
Nov 13, 2024
Merged

grep: replace -1 with -m NUM #809

merged 1 commit into from
Nov 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 13, 2024

  • The -1 flag meant to limit searches to one match per file
  • The -1 flag is incompatible with GNU and BSD grep because they interpret -1 as -C 1, i.e. show one line of context around each match
  • Implement the common way to limit searches by adding -m (maximum match) option
  • Allow -m0 because this is supported in the other versions
  • test1: perl grep -1 pat file1 file2 ---> no longer supported
  • test2: perl grep -m 2 pat file1 file2 ---> two matches per file

@mknos
grep: replace -1 with -m NUM
10a5bd9 
* Previously this grep had a -1 flag meaning one match per file
* The -1 flag is incompatible with GNU and BSD grep because they interpret -1 as -C 1, i.e. show one line of context around each match
* Implement the common way to limit matches by adding -m (maximum) option
* Allow -m0 because this is supported in the other versions
* test1: perl grep -1 pat file1 file2 ---> no longer supported
* test2: perl grep -m 2 pat file1 file2 ---> two matches per file
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Nov 13, 2024
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 13, 2024 08:52 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11813770147

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11812244987: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

briandfoy
briandfoy approved these changes Nov 13, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@briandfoy briandfoy self-assigned this Nov 13, 2024
@briandfoy briandfoy added Type: compatability make it work like GNU or BSD and removed Type: enhancement improve a feature that already exists labels Nov 13, 2024
@briandfoy briandfoy merged commit 4932ef0 into briandfoy:master Nov 13, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: Remove -1 switch. Use -m 1 instead, for GNU compatibility

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy