Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: search results listed in lowercase #776

Merged
merged 1 commit into from
Oct 31, 2024
Merged

grep: search results listed in lowercase #776

merged 1 commit into from
Oct 31, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 31, 2024

  • I noticed that "grep -Fi pattern" was incorrectly listing matching lines in all lowercase
  • When reading the code, this issue had already been fixed in closures $cls_fgrep_xiv and $cls_fgrep_xi
  • Apply same pattern in closures $cls_fgrep_i and $cls_fgrep_iv (avoid modification of $_ in match function)
  • test1: "perl grep -Fin INCLUDE a.c" ---> exercise $cls_fgrep_i (including line numbers)
  • test2: "perl grep -Fiv INT a.c" ---> exercise $cls_fgrep_iv

@mknos
grep: search results listed in lowercase
b23e7cd 
* I noticed that "grep -Fi pattern" was incorrectly listing matching lines in all lowercase
* When reading the code, this issue had already been fixed in closures $cls_fgrep_xiv and $cls_fgrep_xi
* Apply same pattern in closures $cls_fgrep_i and $cls_fgrep_iv (avoid modification of $_ in match function)
* test1: "perl grep -Fin INCLUDE a.c" ---> exercise $cls_fgrep_i (including line numbers)
* test2: "perl grep -Fiv INT a.c" ---> exercise $cls_fgrep_iv
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Oct 31, 2024
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:09 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 31, 2024 07:10 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11607597644

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11607330920: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 72f175b into briandfoy:master Oct 31, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: -Fi shows original line, not line as all lowercase

@briandfoy briandfoy self-assigned this Oct 31, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Oct 31, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy