Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: re-add support for /re/ address-mode #773

Merged
merged 1 commit into from
Oct 29, 2024
Merged

ed: re-add support for /re/ address-mode #773

merged 1 commit into from
Oct 29, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 29, 2024 •
edited
Loading

  • Standard ed allows a regex to be placed in front of a command
  • Previously CalculateLine() supported this but the function was replaced by getAddr()
  • Add a new condition in getAddr() to allow resolving /re/ command prefix to a line number
  • Be careful to support repeated search for empty pattern
  • test1: /include/n ---> search for /include/, resolve line number and run n command
  • test2: //l ---> repeat search using saved /include/ pattern, then run l command on matching line
  • test3: /return/ ---> no command given with pattern still works
  • test4: /a\/b/p --> search pattern includes escaped slash; run p command on matching line

@mknos
ed: re-add support for /re/ address-mode
e03b37d 
* Standard ed allows a regex to be placed in front of a command
* Previously CalculateLine() supported this but the function was replaced by getAddr()
* Add a new condition in getAddr() to allow resolving /re/ command prefix to a line number
* Be careful to support repeated search for empty pattern
* test1: /include/n  ---> search for /include/, resolve line number and run n command
* test2: //l ---> repeat search using saved /include/ pattern, then run l command on next-match
* test3: /return/  ---> no command given with pattern still works
* test4: /a\/b/p --> search pattern includes escaped slash; run p command on result
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 29, 2024
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 29, 2024 05:39 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11567976026

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11557304730: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 0b064c1 into briandfoy:master Oct 29, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: re-add support for /re/ address-mode

@briandfoy briandfoy self-assigned this Oct 29, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 29, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy