-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ed: start breaking up edParse() #771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Oct 28, 2024
- Unhook commands E, e, f, H, h, P, Q and q from the large regex in edParse(); the idea is to remove the large regex entirely
- Commands E, e and f allow zero or one argument; the other commands require no argument
- None of these commands allows an address prefix, e.g. 1,2P is invalid
- When testing against GNU ed I discovered "f FILENAME" should still print the filename when setting it
- Later the remaining commands can be removed from the large regex if calculateLine() function strips address prefix from $_ at start of edParse()
* Unhook commands E, e, f, H, h, P, Q and q from the large regex in edParse(); the idea is to remove the large regex entirely * Commands E, e and f allow zero or one argument; the other commands require no argument * None of these commands allows an address prefix, e.g. 1,2P is invalid * When testing against GNU ed I discovered "f FILENAME" should still print the filename when setting it * Later the remaining commands can be removed from the large regex if calculateLine() function strips address prefix from $_ at start of edParse() %perl ed # start with empty buffer and no saved filename P ---> toggle * prompt *e a.c ---> start editing file a.c 197 *H ---> toggle auto-help *123d ? invalid address ---> error message displays by itself *H ---> disable auto-help *,d ---> delete all lines *h ---> display previous error saved from 123d command invalid address *E ---> reload a.c because I don't want to delete all lines 197 *f ---> show saved filename a.c *f a.c.copy ---> set new filename to write to a.c.copy *1,2d ---> delete first two lines *w ---> write changes to a.c.copy 158 *q
github-actions
bot
added
Type: enhancement
improve a feature that already exists
Priority: low
get to this whenever
Program: ed
The ed program
labels
Oct 28, 2024
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:07 — with
GitHub Actions
Inactive
mknos
temporarily deployed
to
automated_testing
October 28, 2024 06:08 — with
GitHub Actions
Inactive
Pull Request Test Coverage Report for Build 11548331391Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 11548331389Details
💛 - Coveralls |
briandfoy
approved these changes
Oct 28, 2024
briandfoy
added
Status: released
there is a new release with this fix
and removed
Status: accepted
The fix is accepted
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: ed
The ed program
Status: released
there is a new release with this fix
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.