From 1e62033e8958398fcbd0b151f2e893c9a857b6ce Mon Sep 17 00:00:00 2001 From: Michael Mikonos <127171689+mknos@users.noreply.github.com> Date: Fri, 1 Nov 2024 18:47:59 +0800 Subject: [PATCH] kill: reject undocumented -L (#778) * The pod manual doesn't mention -L * Follow BSD version and raise an error for -L, which is not standardised [1] * With this patch kill will exit(1) but it will show signal listing (by default for bad signal spec) 1. https://pubs.opengroup.org/onlinepubs/009696799/utilities/kill.html --- bin/kill | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/kill b/bin/kill index 575a95b5..bea613c9 100755 --- a/bin/kill +++ b/bin/kill @@ -24,7 +24,7 @@ my @signals = getsigs(); my %hsignals = map { $_ => 1 } @signals; my $signal = 'TERM'; -if ( $ARGV[0] =~ /^-l$/i ) { # list signals +if ($ARGV[0] eq '-l') { # list signals siglist(); exit 0; } @@ -73,7 +73,7 @@ sub usage { } sub siglist { - for(my($i)=1;$i<=$#signals;$i++){ + foreach my $i (1 .. $#signals) { printf "%2d:%-6s%s",$i,$signals[$i], ( ($i % 8 == 0) || ($i == $#signals) )?"\n":" "; }