Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm it #140

Open
forresto opened this issue Jan 6, 2017 · 10 comments
Open

npm it #140

forresto opened this issue Jan 6, 2017 · 10 comments

Comments

@forresto
Copy link

forresto commented Jan 6, 2017

Hey @brianchirls it has been a while! Could we get this library on npm?

@brianchirls
Copy link
Owner

Sure. I need to figure out the best way to handle plugins though. Right now, everything uses UMD and depends on either a globally declared Seriously object or requirejs, which I think is not the best way.

Do you have any suggestions on what would work for your use case?

@forresto
Copy link
Author

Hmm...

const Seriously = require('seriously') // or import
const accumulator = require('seriously/effects/seriously.accumulator')
const ascii = require('seriously/effects/seriously.ascii')

const mySeriously = new Seriously({plugins: [accumulator, ascii]})

?

@positlabs
Copy link

I like that approach. The plugins shouldn't need a reference to the main lib

@brianchirls
Copy link
Owner

I was thinking something like that as well. It'd be a breaking change, but I could have it still register the plugin globally if the window.Seriously object is there.

@oleksandr-shvets
Copy link

@brianchirls you can check out the Lebab project, to convert requirejs AMD to the ES6 "imports".
https://lebab.io/

@positlabs
Copy link

UMD has some handy module wrappers. https://github.com/umdjs/umd

@samthomson
Copy link

any progress on this?

@ColorBuffer
Copy link

ugliest javsascript repository i have seen ever

@forresto
Copy link
Author

forresto commented Aug 23, 2020 via email

@offworldcoder
Copy link

offworldcoder commented Oct 27, 2020

Hi, It's been a while and I haven't seen an npm/yarn installation. I found a solution to the problem on stackoverflow. It originally discusses meteor but the solution also applies to npm/yarn https://stackoverflow.com/questions/37739097/am-trying-to-import-seriously-js-into-a-meteor-application-am-receiving-an-obje/64550800#64550800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants