Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive Streams Support #71

Open
ianclegg opened this issue Jan 11, 2017 · 6 comments
Open

Reactive Streams Support #71

ianclegg opened this issue Jan 11, 2017 · 6 comments

Comments

@ianclegg
Copy link

The streams branch looks like it stalled, there were a couple of issues picked up under #53. Was there a serious issue, or did you just get fed up with it? 😉
I could really do with stream support and can offer my time, would you be open to a PR to get it into master and released if I can get it going?

@brettwooldridge
Copy link
Owner

@ianclegg Taking a look at it again this weekend.

If I recall, I didn't like how I (had to?) module the stdin stream. All the streams (stdout, stderr, and stdin) are Pushlishers. Obviously, stdout and stderr are publishers of data, but it is kinda strange if stdin is a publisher. That needs to be inverted...

@ianclegg
Copy link
Author

Yer, I was looking at this too. It might be quite a big change. I need to integrate with Akka Streams. In end, rather than surface a Reactive Streams interface from NuProcess I decided to wrap it with a little like vietj. Happy for you to close the issue

@vietj
Copy link
Contributor

vietj commented Jan 14, 2017

it would be great to offer back pressure support indeed, not necessarily via Reactive Streams, as adapter can always be done, but whatever :-)

@huntc
Copy link

huntc commented Aug 15, 2017

As an update to this case, we (Lightbend) are providing a reactive streams implementation via Akka streams here: typesafehub/akka-contrib-extra#60.

@brettwooldridge
Copy link
Owner

Nice. We do have a streams branch, but development is on hold due to time constraints. The trickiest part is getting back pressure right.

@huntc
Copy link

huntc commented Aug 16, 2017

Implementing the reactive streams API directly is tricky, as you've no doubt discovered. :-) While Akka streams will pull in undesirable dependencies for your library, there are other reactive streams libraries that may be better for you. For example, RxJava.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants