-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactive Streams Support #71
Comments
@ianclegg Taking a look at it again this weekend. If I recall, I didn't like how I (had to?) module the stdin stream. All the streams (stdout, stderr, and stdin) are Pushlishers. Obviously, stdout and stderr are publishers of data, but it is kinda strange if stdin is a publisher. That needs to be inverted... |
Yer, I was looking at this too. It might be quite a big change. I need to integrate with Akka Streams. In end, rather than surface a Reactive Streams interface from NuProcess I decided to wrap it with a little like vietj. Happy for you to close the issue |
it would be great to offer back pressure support indeed, not necessarily via Reactive Streams, as adapter can always be done, but whatever :-) |
As an update to this case, we (Lightbend) are providing a reactive streams implementation via Akka streams here: typesafehub/akka-contrib-extra#60. |
Nice. We do have a streams branch, but development is on hold due to time constraints. The trickiest part is getting back pressure right. |
Implementing the reactive streams API directly is tricky, as you've no doubt discovered. :-) While Akka streams will pull in undesirable dependencies for your library, there are other reactive streams libraries that may be better for you. For example, RxJava. |
The streams branch looks like it stalled, there were a couple of issues picked up under #53. Was there a serious issue, or did you just get fed up with it? 😉
I could really do with stream support and can offer my time, would you be open to a PR to get it into master and released if I can get it going?
The text was updated successfully, but these errors were encountered: