Add pyright + fix caught typos

Author: brentyi

.github/workflows/pyright.yml

@@ -0,0 +1,31 @@
+name: pyright
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  pyright:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.12"]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v1
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Install dependencies
+        run: |
+          pip install uv
+          uv pip install --system -e .
+          uv pip install --system jax
+          uv pip install --system git+https://github.com/brentyi/jaxls.git
+          uv pip install --system pyright
+      - name: Run pyright
+        run: |
+          pyright .

3_aria_inference.py

@@ -188,7 +188,7 @@ def main(args: Args) -> None:
             hamer_detections,
             aria_detections,
             points_data=points_data,
-            splat_path=splat_path,
+            splat_path=traj_paths.splat_path,
             floor_z=floor_z,
         )
         while True:

pyproject.toml

@@ -28,7 +28,8 @@ dependencies = [
     "tensorboardX",
     "loguru",
     "projectaria-tools[all]",
-    "opencv-python"
+    "opencv-python",
+    "gdown",
 ]
 
 [tool.setuptools.package-data]

src/egoallo/data/amass.py

@@ -1,12 +1,11 @@
 from pathlib import Path
-from typing import Any, Literal, cast
+from typing import Any, Literal, assert_never, cast
 
 import h5py
 import numpy as np
 import torch
 import torch.utils
 import torch.utils.data
-from typing_extensions import assert_never
 
 from .dataclass import EgoTrainingData
 

src/egoallo/data/dataclass.py

@@ -58,7 +58,7 @@ def joints_wrt_world(self) -> Tensor:
 
     @staticmethod
     def load_from_npz(
-        body_model: fncsmpl.SmplModel,
+        body_model: fncsmpl.SmplhModel,
         path: Path,
         include_hands: bool,
     ) -> EgoTrainingData:

src/egoallo/network.py

@@ -2,7 +2,7 @@
 
 from dataclasses import dataclass
 from functools import cache, cached_property
-from typing import Literal
+from typing import Literal, assert_never
 
 import numpy as np
 import torch
@@ -11,7 +11,6 @@
 from loguru import logger
 from rotary_embedding_torch import RotaryEmbedding
 from torch import Tensor, nn
-from typing_extensions import assert_never
 
 from .fncsmpl import SmplhModel, SmplhShapedAndPosed
 from .tensor_dataclass import TensorDataclass

src/egoallo/tensor_dataclass.py

@@ -1,8 +1,7 @@
 import dataclasses
-from typing import Any, Callable
+from typing import Any, Callable, Self, dataclass_transform
 
 import torch
-from typing_extensions import Self, dataclass_transform
 
 
 @dataclass_transform()

src/egoallo/training_utils.py

@@ -8,10 +8,18 @@
 import time
 import traceback as tb
 from pathlib import Path
-from typing import Any, Dict, Generator, Iterable, Protocol, Sized, overload
+from typing import (
+    Any,
+    Dict,
+    Generator,
+    Iterable,
+    Protocol,
+    Sized,
+    get_type_hints,
+    overload,
+)
 
 import torch
-from typing_extensions import get_type_hints
 
 
 def flattened_hparam_dict_from_dataclass(

src/egoallo/transforms/_base.py

@@ -1,10 +1,20 @@
 import abc
-from typing import ClassVar, Generic, Tuple, Type, TypeVar, Union, overload
+from typing import (
+    ClassVar,
+    Generic,
+    Self,
+    Tuple,
+    Type,
+    TypeVar,
+    Union,
+    final,
+    overload,
+    override,
+)
 
 import numpy as onp
 import torch
 from torch import Tensor
-from typing_extensions import Self, final, override
 
 GroupType = TypeVar("GroupType", bound="MatrixLieGroup")
 SEGroupType = TypeVar("SEGroupType", bound="SEBase")

src/egoallo/transforms/_se3.py

@@ -1,12 +1,11 @@
 from __future__ import annotations
 
 from dataclasses import dataclass
-from typing import cast
+from typing import Union, cast, override
 
 import numpy as np
 import torch
 from torch import Tensor
-from typing_extensions import Union, override
 
 from . import _base
 from ._so3 import SO3