From 1c2f6fe510b761a6ed8525a284e5870dbc351c5e Mon Sep 17 00:00:00 2001 From: Arya Massarat <23412689+aryarm@users.noreply.github.com> Date: Tue, 18 Jun 2024 08:59:49 -0700 Subject: [PATCH] add notes about keeping the lowest supported numpy version in sync with the CI --- .github/workflows/build.yml | 1 + setup.py | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index aa91496..347a130 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -110,6 +110,7 @@ jobs: run: | pytest --cov cyvcf2 --cov-report term-missing + # make sure to keep this numpy version in sync with setup.py - name: Test with oldest numpy that we support if: contains(fromJson('["3.7"]'), matrix.python-version) run: | diff --git a/setup.py b/setup.py index 35684cb..ef361aa 100644 --- a/setup.py +++ b/setup.py @@ -290,6 +290,7 @@ def run(self): ], ), python_requires=">=3.7", + # make sure to keep this numpy version in sync with build.yml install_requires=["numpy>=1.16.0", "coloredlogs", "click"], include_package_data=True, zip_safe=False,