Should session[:mobile_view] be checked in is_mobile_device?

[lyslim]

Dear all,

I got stuck when I tried to alter session[:mobile_view] to switch between html page and mobile page, hence I changed the method is_mobile_device? a bit like below:

def is_mobile_device?
    if session[:mobile_view]
      session[:mobile_view] == 'true'
    else
      request.user_agent.to_s.downcase =~ Regexp.new(ActionController::MobileFu::MOBILE_USER_AGENTS)
    end
end

Is this modification safe? Are there any better solution for this? Thanks!

@benlangfeld, seems you are active on creating the gem, could you kindly comment? Thanks.

[benlangfeld]

It seems you have prepared this patch against this repository, which is significantly out of date. You should check out my fork for the version published as a gem. The existing method is this:

 def is_mobile_device?
   !!mobile_device
 end

 def mobile_device
   request.headers['X_MOBILE_DEVICE']
 end

You might try:

def is_mobile_device?
  !!mobile_device || session[:mobile_view].present?
end

[lyslim]

Hmmm, then I would continue on the plugin as I don't foresee a big advantage on the gem?

[benlangfeld]

This project is abandoned. Please see the active fork at http://github.com/benlangfeld/mobile-fu. Please test with the released gem and master branch of the new home for the project, and file an issue on the other repo if you still have problems.

See #40.