small fixes on CLI behavior [AWS SSO + Cloudformation Exception]

Author: deleugpn

src/Commands/Connect.php

@@ -38,6 +38,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         /** @var string $awsProfile */
         $awsProfile = $input->getOption('profile');
 
+        putenv('AWS_PROFILE=' . $awsProfile);
+
         $accountId = $this->getCurrentAwsAccountId($awsProfile);
         // TODO verbose only
         IO::writeln('Current AWS account ID: ' . $accountId);
@@ -100,7 +102,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         IO::spin('connecting');
 
         $cloudFormationClient = new CloudFormationClient([
-            'profile' => $awsProfile,
             'region' => $details['region'],
         ]);
         IO::verbose(['Deploying CloudFormation stack']);
@@ -139,13 +140,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     private function getCurrentAwsAccountId(string $profile): string
     {
         $sts = new StsClient([
-            'profile' => $profile,
+            'region' => 'us-east-1',
         ]);
-        $accountId = $sts->getCallerIdentity()->toArray()['Account'] ?? null;
-        if (! $accountId) {
+
+        return $sts->getCallerIdentity()->toArray()['Account'] ??
             throw new RuntimeException('Could not determine the AWS account ID');
-        }
-        return $accountId;
     }
 
     private function selectTeam(BrefCloudClient $brefCloud): int

src/Helpers/CloudFormation.php

@@ -122,7 +122,7 @@ private function retrieveDetailedDeployError(string $stackName): ?string
             'StackName' => $stackName,
         ])->toArray();
         if (! empty($stack['Stacks'][0]['StackStatusReason'])) {
-            throw $stack['Stacks'][0]['StackStatusReason'];
+            throw new Exception($stack['Stacks'][0]['StackStatusReason']);
         }
 
         // Else try to retrieve the events