Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user know if they won't be able to receive payments through their Lightning Address #843

Closed
erdemyerebasmaz opened this issue Mar 21, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@erdemyerebasmaz
Copy link
Collaborator

Do not show LN Address QR to the user if

  • minSendable is less than 1 sats, or greater than maxSendable
  • If maxSendable is smaller than minSendable due to low fee limit, tell user to increase their fee limit
@erdemyerebasmaz erdemyerebasmaz added the enhancement New feature or request label Mar 21, 2024
@ok300
Copy link
Collaborator

ok300 commented Mar 25, 2024

Are these checks not already done in the SDK?

@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Mar 25, 2024

Are these checks not already done in the SDK?

@ok300 No, not at this stage.

The lightning address is created through our LNURL server and it only returns callbackURL. Validation happens on client side.

For proportional fee of 0.4% & minimum channel setup fee from the connected LSP as 3000 sats;
Let's assume user has set their automatic channel setup fee limit to 1 sats and they have no inbound liquidity, their maxSendable would be 250 sats, which would fall below minSendable. In this case, the QR code should be hidden and user has to be informed to increase their automatic channel setup fee limit

If minSendable is less than 1 or larger than maxSendable for any other reason- e.g.; minimum channel setup fee from the connected LSP is either set to 0 or is more than maxSendable- than the QR should be hidden as the user won't be able to receive any payments.

@ok300
Copy link
Collaborator

ok300 commented Mar 25, 2024

I see, makes sense. Thanks.

@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Mar 26, 2024

Decided not to hide ln address as they are reusable. We'll convey the user they won't be able to receive payments at the time and as to reasons* why on the UI.

*: high LSP fees, low channel setup fee limit setting etc.

@erdemyerebasmaz erdemyerebasmaz changed the title Do not show invalid lightning addresses to the user Let user know if they won't be able to receive payments through their Lightning Address Mar 26, 2024
@erdemyerebasmaz
Copy link
Collaborator Author

Closing in favor of #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants