Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent type for byte arrays in public structs #878

Open
ok300 opened this issue Mar 20, 2024 · 0 comments
Open

Consistent type for byte arrays in public structs #878

ok300 opened this issue Mar 20, 2024 · 0 comments
Labels
good first issue Good for newcomers sdk-core

Comments

@ok300
Copy link
Contributor

ok300 commented Mar 20, 2024

Sometimes we return fields like a payment_hash

  • as a Vec<u8>, like in SwapInfo::payment_hash
  • as a String, like in LnPaymentDetails::payment_hash

We should choose a type and use it consistently in all binary fields in public structs (preimage, etc).
@ok300 ok300 added good first issue Good for newcomers sdk-core labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers sdk-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ok300