Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reliability of binding generation #747

Open
JssDWt opened this issue Jan 26, 2024 · 2 comments
Open

Improve reliability of binding generation #747

JssDWt opened this issue Jan 26, 2024 · 2 comments
Assignees

Comments

@JssDWt
Copy link
Contributor

JssDWt commented Jan 26, 2024

The binding generation currently depends on a number of factors, including the operating system you're on. Like the kotlin formatter for react native behaves differently on macos-12 and macos-13.

Suggestion:
Create a nix environment to generate the flutter and react native bindings in. This would make binding generation reproducible between platforms.

@ok300
Copy link
Contributor

ok300 commented Jan 27, 2024

The trouble seems to be that on macos-latest homebrew installs either 1.0.1 or 1.1.1 of ktlint:

https://github.com/breez/breez-sdk/blob/c60b12264e7f9103283c8fa4c57e2c3423faaeec/.github/workflows/main.yml#L206

This doesn't happen on macos-13. I think its because of caching or homebrew local mirrors that GH might be experimenting with.

I agree a nix way would be better.

@hydra-yse hydra-yse self-assigned this Jan 27, 2024
@ok300
Copy link
Contributor

ok300 commented Jan 29, 2024

Related: breez/breez-sdk-docs#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants