Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BIP353 with onchain address #1161

Open
danielgranhao opened this issue Jan 21, 2025 · 1 comment
Open

Support BIP353 with onchain address #1161

danielgranhao opened this issue Jan 21, 2025 · 1 comment

Comments

@danielgranhao
Copy link
Contributor

Right now, for parsing BIP353 addresses, we parse the resulting BIP21 using custom logic that only looks for a BOLT12 offer or an LNURL. We should support resolving to a bitcoin address as well.

This may be fixed by merging this custom BIP21 parsing logic with our other BIP21 parsing in parse_core that uses the bip21 crate. This would also allow BIP21 with no Bitcoin address to be parsed (right now, these can only be parsed when fetched using BIP353).

@kingonly
Copy link
Member

No need to do anything atm, we need to see how the market will adopt it first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants