Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Return payment hash after claiming reverse swap #1159

Open
dleutenegger opened this issue Jan 20, 2025 · 2 comments
Open

Feature request: Return payment hash after claiming reverse swap #1159

dleutenegger opened this issue Jan 20, 2025 · 2 comments

Comments

@dleutenegger
Copy link

In order to provide the user a useful push notification for a claimed reverse swap, it would be useful if the claim_reverse_swap method would return at least the payment_hash of the related payment.

This would allow us to open the payment details when clicking the notification or to display information such as the amount of the reverse swap.

@Patti88
Copy link

Patti88 commented Feb 12, 2025

This feature request makes sense. I'd be happy to explore implementing this. I'll take a look at the code and see how best to integrate returning the payment_hash.

@roeierez
Copy link
Member

Makes sense. The code that maps the response to the user is here: https://github.com/breez/breez-sdk-greenlight/blob/main/libs/sdk-core/src/breez_services.rs#L1075C14-L1075C39

The full info contains the invoice and we can add the invoice to to the mapping logic so it will exist also in ReverseSwapInfo returned structure.

Patti88 added a commit to Patti88/breez-sdk-greenlight that referenced this issue Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants