Add Troubleshooting Android section #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good overall! Thank you @dangeross
Added some notes on wording, suggested a new heap space value & a section recommendation about when code obfuscation may kick in and cause issues re: JNA library.
|
|
||
| Starting with this 1.8.20 release, the Kotlin K2 compiler has a preview version of the serialization plugin. It's recommended for users to upgrade their Kotlin version to at least 1.8.20 or [set up the serialization plugin](https://github.com/Kotlin/kotlinx.serialization?tab=readme-ov-file#setup) on their projects explicitly with older versions. | ||
|
|
||
| ## JNA library |
There was a problem hiding this comment.
JNA library code obfuscation issue may not be apparent until users compile their apps on "release" mode with maximum optimization and minimal footprint size that'll be used when deploying & publishing their app.
I think we should add a warning about this in this section.
Co-authored-by: Erdem Yerebasmaz <[email protected]>
dangeross
force-pushed
the
savage-android-troubleshooting
branch
from
f0e4d39
to
3fdf938
Compare
Co-authored-by: Erdem Yerebasmaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171