Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FitFfmDT(addIntercept = TRUE/FALSE) ERROR #65

Open
JustinMShea opened this issue Dec 5, 2021 · 2 comments
Open

FitFfmDT(addIntercept = TRUE/FALSE) ERROR #65

JustinMShea opened this issue Dec 5, 2021 · 2 comments
Assignees
@midoshammaa @JustinMShea @martinrd3D
Labels
bug enhancement

Comments

@JustinMShea
Copy link
Collaborator

JustinMShea commented Dec 5, 2021 •
edited
Loading

Document additional restrictions on choice of addIntercept = TRUE. Make sure docs reflect functions here.

Also, please see https://github.com/braverock/FactorAnalytics/blob/master/R/fmTstats.R#L79-L89

And also: https://github.com/braverock/FactorAnalytics/blob/master/R/fitFfm.R#L193-L200
JustinMShea added a commit that referenced this issue Dec 5, 2021
@JustinMShea
fixed a bug in the wrapper function pertaining to passing fitFfm a da…
1ce071d 
…ta.table. Updated docs related to #65. Minor code formats
JustinMShea added a commit that referenced this issue Dec 5, 2021
@JustinMShea
Should be false (see #65) but FitFfmDT still thows an error
a9f5aa4
JustinMShea added a commit that referenced this issue Dec 10, 2021
@JustinMShea
#65 #25 restore fitFfm wrapper function for now
9d91051
@JustinMShea JustinMShea changed the title FitFfm documentation for addIntercept FitFfm(addIntercept = TRUE/FALSE) ERROR Dec 10, 2021
@JustinMShea JustinMShea mentioned this issue Dec 20, 2021
Open
@JustinMShea JustinMShea changed the title FitFfm(addIntercept = TRUE/FALSE) ERROR FitFfmDT(addIntercept = TRUE/FALSE) ERROR Dec 20, 2021
@JustinMShea
Copy link
Collaborator Author

@midoshammaa @martinrd3D Can we close this issue? where are with this?

@JustinMShea
Copy link
Collaborator Author

@midoshammaa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@midoshammaa midoshammaa

@JustinMShea JustinMShea

@martinrd3D martinrd3D

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@midoshammaa @JustinMShea @martinrd3D