Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgetful browsing deletes storage in normal profile if browser launched in an Incognito profile via command line #39107

Open
2 of 6 tasks
whosithat opened this issue Jun 17, 2024 · 8 comments · May be fixed by brave/brave-core#27111 or brave/brave-core#27176
Assignees
Labels
feature/shields/forgetful-browsing OS/Desktop OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@whosithat
Copy link

Description

Hey everybody,

to face this issue, Brave Shields needs to be enabled and especially the option "forget me when I leave the page" needs to be enabled.
Using then incognito mode, by starting it directly from the taskbar, it deletes all cookies in the default userprofile.

Steps to reproduce

  1. Open Brave with the default user profile (%localappdata%\BraveSoftware\Brave-Browser\User Data\Default)
  2. Open any page and log into the site (e.g. facebook)
  3. Close Brave
  4. Open Brave Incognito by doing a right click into the taskbar brave icon
  5. Close the Brave Incognito Windows
  6. Open Brave again with the default user profile, the cookies should be deleted, you should recognize it by being logged out

Actual result

The cookies in the default user profile gets deleted after closing the incognito mode windows.

Expected result

The cookies of the default user profile stays untouched

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.67.116 Chromium: 126.0.6478.71 (Offizieller Build) (64-Bit)
Revision | f4237fe448716e50cca6e827ff87ffd701c7d0c7
OS | Windows 10 Version 22H2 (Build 19045.4529)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@ShivanKaul
Copy link
Collaborator

You're saying:

to face this issue, Brave Shields needs to be enabled and especially the option "forget me when I leave the page" needs to be enabled.

If you've enabled this option, it is expected that closing the tab will delete all cookies. This has nothing to do with Incognito or Private Window, it's what "forget me when I leave the page" does.

@ShivanKaul
Copy link
Collaborator

Open Brave Incognito by doing a right click into the taskbar brave icon
Close the Brave Incognito Windows
Open Brave again with the default user profile, the cookies should be deleted, you should recognize it by being logged out

When you open Brave again at this point, do you see your old tabs? Or does it start afresh because you launched a Private Window in between?

@whosithat
Copy link
Author

Open Brave Incognito by doing a right click into the taskbar brave icon
Close the Brave Incognito Windows
Open Brave again with the default user profile, the cookies should be deleted, you should recognize it by being logged out

When you open Brave again at this point, do you see your old tabs? Or does it start afresh because you launched a Private Window in between?

Exactly, I can see all the old tabs and the session within the default user profile will be loaded completly successful again.

Launching a private windows and closing it afterwards will delete all the site data of the open tabs within the default user profile.

Brave shield and the option "forget me when I leave the page" believes that the tabs have been closed, as the private window will be started without any tabs, so it thinks the default user session tabs have been closed, but they haven't.

As far as I can result this from the user point of view, I believe that the problem is the architecture of the Brave shield, as they are running within the chrome backend and so it's not depending to the specific user profile, which is currently active. But that's just guessing.

@rebron rebron added the needs-investigation A bug not 100% confirmed/fixed label Jun 21, 2024
@ShivanKaul
Copy link
Collaborator

Just a quick update, I want to repro this on my Windows machine which has been finicky, so will get back to this. I can't repro on MacOS.

@whosithat
Copy link
Author

Hey @ShivanKaul,

any updates on this? I saw some progress in an linked item, but looks like that it's stuck now for a while..

@ShivanKaul
Copy link
Collaborator

It fell off the radar, we're working on an important anti-fingerprinting fix but should get to this soon.

@whosithat
Copy link
Author

Hey @ShivanKaul,

any update on this? It looks like, that it's stuck again, at least the development item is waiting for an approval.

@ShivanKaul ShivanKaul added priority/P3 The next thing for us to work on. It'll ride the trains. feature/shields/forgetful-browsing and removed needs-investigation A bug not 100% confirmed/fixed labels Nov 24, 2024
@ShivanKaul ShivanKaul changed the title Only incognito browsing deletes cookies from Default User Profile Forgetful browsing deletes storage in normal profile if browser launched in an Incognito profile via command line Nov 24, 2024
@whosithat
Copy link
Author

Hi guys,

sorry, I really don't want to upset you, but is there any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment