Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$removeparam not working correctly #44663

Open
3 of 6 tasks
ghost opened this issue Mar 14, 2025 · 2 comments
Open
3 of 6 tasks

$removeparam not working correctly #44663

ghost opened this issue Mar 14, 2025 · 2 comments
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@ghost
Copy link

ghost commented Mar 14, 2025

Description

$removeparam doesn't work correctly in Brave breaking images and the maps. Bing is the only place I have notice this breakage, and it is because of the AdGuard URL Tracking filter list.

This has happened for a while this year. Basically, instead of just removing the param and use the same URL without the param, for some reason this feature is allowing Bing to change the whole URL making it invalid.

In the case of Bing, it is caused by this rule In this line $removeparam=FORM,domain=bing.com found in https://github.com/AdguardTeam/FiltersRegistry/blob/7ad2e5caafb2105c53667dc1b963ed30f4d6e4f3/filters/filter_17_TrackParam/filter.txt#L714

And this is what Bing does with the $removeparam

Image

For example:

Original URL:

https://www.bing.com/maps/overlaybfpr?q=test&filters=MapCardType%3A%22unknown%22%20direction_partner%3A%22maps%22%20tid%3A%22D409E56A9E234878935D467B2EAE9977%22&mapcardtitle=&appid=E18E19EF-764F-41A9-B53E-6E98AE519695&p1=&count=18&ecount=18&first=0&efirst=1&localMapView=10.32674115812162,-84.49413299560533,9.721577829847192,-83.9180374145505&cardtype=unknown&FORM=MPSRBX&ads=1&cp=10.024300723707228~-84.20608520507812&MCIG=D409E56A9E234878935D467B2EAE9977&rh=tt&rhd=v9D0

After $removeparam

https://e86303.dscx.akamaiedge.net/maps/overlaybfpr?q=test&filters=MapCardType%3A%22unknown%22%20direction_partner%3A%22maps%22%20tid%3A%22D409E56A9E234878935D467B2EAE9977%22&mapcardtitle=&appid=E18E19EF-764F-41A9-B53E-6E98AE519695&p1=&count=18&ecount=18&first=0&efirst=1&localMapView=10.32674115812162,-84.49413299560533,9.721577829847192,-83.9180374145505&cardtype=unknown&ads=1&cp=10.024300723707228~-84.20608520507812&MCIG=D409E56A9E234878935D467B2EAE9977&rh=tt&rhd=v9D0

As you can see it switches the URL from Bing to e86303.dscx.akamaiedge for no reason. uBlock doesn't do that so it is not an issue about removing the FORM parameter, because using another parameter causes the same issue.

for example: $removeparam=ads,domain=bing.com

In the case of images it is the same issue, where Bing just switches to the same e86303.dscx.akamaiedge when you search for an image and click on any image in the result to see it bigger and get the link and all that.

Steps to reproduce

  1. Open Bing maps or Bing images
  2. Search for any word.
  3. Maps will not display the searching results or location and images will give an error when you click on an image to see it bigger.
  4. if AdGuard URL Tracking filter is disabled from Regional lists or $removeparam=FORM,domain=bing.com,badfilter is added to the custom rules it works.
  5. Use the same filter in uBlock, and you will notice the FORM parameter gets removed but without redirecting the page to some non-bing page.

Actual result

Image

Image

Expected result

Image

Image

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

1.78.41 Chromium: 134.0.6998.95 (Official Build) nightly (64-bit)
Windows 11 Version 24H2 (Build 26100.3476)

Android device

  • Brand/model: Samsung
  • Android version: 14

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@ghost ghost added OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 14, 2025
@ghost ghost changed the title $removeparam not working correctly and breaks Bing. $removeparam not working correctly Mar 14, 2025
@ghost
Copy link
Author

ghost commented Mar 14, 2025

This is not a regression, because I went back to 1.48.24 Chromium: 108.0.5359.71, around the time this feature was released years ago, and the issue is still there, so whatever Bing changed recently is breaking the maps and images for the way $removeparam is being done in Brave, because it works fine in uBlock, so it is not the removing of the parameter the problem as tested by using other parameters like ads.

So for now the only solution will be $removeparam=FORM,domain=bing.com,badfilter to keep using the Adguard list.

@ghost
Copy link
Author

ghost commented Mar 15, 2025

@ShivanKaul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Development

No branches or pull requests

0 participants