Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C133] Review NoStreams suppressed warnings #42632

Open
6 tasks
samartnik opened this issue Dec 3, 2024 · 0 comments
Open
6 tasks

[C133] Review NoStreams suppressed warnings #42632

samartnik opened this issue Dec 3, 2024 · 0 comments
Labels
dev-concern OS/Android Fixes related to Android browser functionality

Comments

@samartnik
Copy link
Contributor

samartnik commented Dec 3, 2024 •
edited
Loading

Description

In C133 upstream added NoStreams lint error. For now we just suppress it as it requires different fix in different cases. This is a follow up to address this issue.
The upstream change is https://chromium.googlesource.com/chromium/src/+/31928c984432e9d2f7c71438a716a417f378dff5
Corresponding doc for the warning is here https://chromium.googlesource.com/chromium/src/+/main/styleguide/java/java.md#Streams

Steps to reproduce

  1. n/a

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version

n/a

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@samartnik samartnik added dev-concern OS/Android Fixes related to Android browser functionality labels Dec 3, 2024
samartnik added a commit to samartnik/brave-core that referenced this issue Dec 3, 2024
@samartnik
[Android] Fixes for NoStreams lint errors
b23a86e 
For now we just suppress them as there is no uniform fix for all of them. Follow up issue is created to address this brave/brave-browser#42632

Chromium change:
https://chromium.googlesource.com/chromium/src/+/31928c984432e9d2f7c71438a716a417f378dff5

Reland "Android: Add Error Prone warning against Java stream() apis"

This reverts commit 8ff33dbc1ddcaabcf4da1b92868bfa26ae34ba8f.

Reason for reland: Internal fix landed

Original change's description:
> Revert "Android: Add Error Prone warning against Java stream() apis"
>
> This reverts commit e910d272c026bf1463f54ea17ce6fb16f55513cf.
>
> Reason for revert: crbug.com/344943957#comment13
>
> Original change's description:
> > Android: Add Error Prone warning against Java stream() apis
> >
> > And minor clarifying tweaks to style guide wrt streams
> >
> > Bug: 344943957
> > Change-Id: I90b976866c8f3f71826459b7d3097692e1f533b4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042674
> > Auto-Submit: Andrew Grieve <[email protected]>
> > Commit-Queue: Andrew Grieve <[email protected]>
> > Reviewed-by: Henrique Nakashima <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1388426}
>
> Bug: 344943957
> Change-Id: Ib9b3d8db9f47383eaced5192a15e7cac6427da35
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6051419
> Reviewed-by: Henrique Nakashima <[email protected]>
> Auto-Submit: Keigo Oka <[email protected]>
> Commit-Queue: Henrique Nakashima <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Andrew Grieve <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1388467}

Bug: 344943957
samartnik added a commit to brave/brave-core that referenced this issue Dec 3, 2024
@samartnik
[Android] Fixes for NoStreams lint errors
f4bc408 
For now we just suppress them as there is no uniform fix for all of them. Follow up issue is created to address this brave/brave-browser#42632

Chromium change:
https://chromium.googlesource.com/chromium/src/+/31928c984432e9d2f7c71438a716a417f378dff5

Reland "Android: Add Error Prone warning against Java stream() apis"

This reverts commit 8ff33dbc1ddcaabcf4da1b92868bfa26ae34ba8f.

Reason for reland: Internal fix landed

Original change's description:
> Revert "Android: Add Error Prone warning against Java stream() apis"
>
> This reverts commit e910d272c026bf1463f54ea17ce6fb16f55513cf.
>
> Reason for revert: crbug.com/344943957#comment13
>
> Original change's description:
> > Android: Add Error Prone warning against Java stream() apis
> >
> > And minor clarifying tweaks to style guide wrt streams
> >
> > Bug: 344943957
> > Change-Id: I90b976866c8f3f71826459b7d3097692e1f533b4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6042674
> > Auto-Submit: Andrew Grieve <[email protected]>
> > Commit-Queue: Andrew Grieve <[email protected]>
> > Reviewed-by: Henrique Nakashima <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1388426}
>
> Bug: 344943957
> Change-Id: Ib9b3d8db9f47383eaced5192a15e7cac6427da35
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6051419
> Reviewed-by: Henrique Nakashima <[email protected]>
> Auto-Submit: Keigo Oka <[email protected]>
> Commit-Queue: Henrique Nakashima <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Reviewed-by: Andrew Grieve <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1388467}

Bug: 344943957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev-concern OS/Android Fixes related to Android browser functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samartnik