Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear conversation link button should not have min height #42631

Open
2 of 6 tasks
srirambv opened this issue Dec 3, 2024 · 1 comment
Open
2 of 6 tasks

Clear conversation link button should not have min height #42631

srirambv opened this issue Dec 3, 2024 · 1 comment
Labels
browser-ai OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA/Yes

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 3, 2024

Description

Clear conversation link button should not have min height

Steps to reproduce

  1. Setup local model
  2. Set context size to 800
  3. Ask a question Write 1500 word essay on bravery
  4. Once response starts shows warning message about conversation length
  5. Clear conversation button has min height set which causes the last line to not align properly

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.74.15 Chromium: 131.0.6778.85 (Official Build) beta (64-bit)
Revision d1293587128488865fa61e9fa277dd54aa2270b0
OS Windows 11 Version 23H2 (Build 22631.4460)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @petemill @aguscruiz @Brave-Matt
@srirambv srirambv added browser-ai OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA/Yes labels Dec 3, 2024
@aguscruiz
Copy link

Agree, should be a link instead of a button, I think. At least visually

@srirambv srirambv mentioned this issue Dec 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
browser-ai OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA/Yes
Projects
Browser AI
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aguscruiz @srirambv