Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widevine toggling should prompt for relaunch via button instead of popup #42630

Open
3 of 6 tasks
ShivanKaul opened this issue Dec 3, 2024 · 0 comments
Open
3 of 6 tasks

Comments

@ShivanKaul
Copy link
Collaborator

Description

In brave://settings/extensions, we have a number of settings that users can toggle and that require a browser restart. All of them except Widevine show up a Relaunch button next to the toggle when the setting is changed. Widevine toggling brings up a popup. For uniformity, we should do the same thing across button toggling.

Steps to reproduce

  1. Go to brave://settings/extensions
  2. Toggle Widevine (default on)

Actual result

Image

See popup asking the user to Relaunch Now

Expected result

A Relaunch button similar to what shows up when Media Router is toggled

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

All

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant