Use size_t around base::span size/offset arguments
#42627
Assignees
Labels
dev-concern
feature/web3/wallet/core
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Desktop
QA/No
release-notes/exclude
Milestone
Comments
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Dec 3, 2024
There's some tightening around values passed into span, with `StrictNumeric<size_t>` being enforced. This is mostly unimportant when dealing with compile-time values, as they can be validated on the spot, however it does affect several places where the value is unknown at runtime, and a signed value was being used. Chromium changes: https://chromium.googlesource.com/chromium/src/+/4937ad9ae64d9d3f05d13c9d041769432a12281b ``` commit 4937ad9ae64d9d3f05d13c9d041769432a12281b Author: Peter Kasting <[email protected]> Date: Tue Nov 26 22:58:16 2024 +0000 Use StrictNumeric<size_t> for more span methods. Changes subspan(), split_at(), at(), and get_at() to match pre-existing usage in constructors, first(), last(), etc. Bug: 364987728 ``` Resolves brave/brave-browser#42627
24 tasks
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Dec 3, 2024
There's some tightening around values passed into span, with `StrictNumeric<size_t>` being enforced. This is mostly unimportant when dealing with compile-time values, as they can be validated on the spot, however it does affect several places where the value is unknown at runtime, and a signed value was being used. Chromium changes: https://chromium.googlesource.com/chromium/src/+/4937ad9ae64d9d3f05d13c9d041769432a12281b ``` commit 4937ad9ae64d9d3f05d13c9d041769432a12281b Author: Peter Kasting <[email protected]> Date: Tue Nov 26 22:58:16 2024 +0000 Use StrictNumeric<size_t> for more span methods. Changes subspan(), split_at(), at(), and get_at() to match pre-existing usage in constructors, first(), last(), etc. Bug: 364987728 ``` Resolves brave/brave-browser#42627
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Dec 3, 2024
There's some tightening around values passed into span, with `StrictNumeric<size_t>` being enforced. This is mostly unimportant when dealing with compile-time values, as they can be validated on the spot, however it does affect several places where the value is unknown at runtime, and a signed value was being used. Chromium changes: https://chromium.googlesource.com/chromium/src/+/4937ad9ae64d9d3f05d13c9d041769432a12281b ``` commit 4937ad9ae64d9d3f05d13c9d041769432a12281b Author: Peter Kasting <[email protected]> Date: Tue Nov 26 22:58:16 2024 +0000 Use StrictNumeric<size_t> for more span methods. Changes subspan(), split_at(), at(), and get_at() to match pre-existing usage in constructors, first(), last(), etc. Bug: 364987728 ``` Resolves brave/brave-browser#42627
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Dec 3, 2024
There's some tightening around values passed into span, with `StrictNumeric<size_t>` being enforced. This is mostly unimportant when dealing with compile-time values, as they can be validated on the spot, however it does affect several places where the value is unknown at runtime, and a signed value was being used. Chromium changes: https://chromium.googlesource.com/chromium/src/+/4937ad9ae64d9d3f05d13c9d041769432a12281b ``` commit 4937ad9ae64d9d3f05d13c9d041769432a12281b Author: Peter Kasting <[email protected]> Date: Tue Nov 26 22:58:16 2024 +0000 Use StrictNumeric<size_t> for more span methods. Changes subspan(), split_at(), at(), and get_at() to match pre-existing usage in constructors, first(), last(), etc. Bug: 364987728 ``` Resolves brave/brave-browser#42627
brave-builds
added
feature/web3/wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This is an improvement that is being done by upstream, and that we should adopt as well.
The text was updated successfully, but these errors were encountered: