Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already purchased Brave VPN? link to be shown for existing user on VPN card widget in the NTP #42615

Closed
1 of 6 tasks
MadhaviSeelam opened this issue Dec 2, 2024 · 4 comments · Fixed by brave/brave-core#26853

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 2, 2024

Description

Found while testing brave/brave-core#26189
Currently VPN card widget in the NTP doesn't show Already purchased Brave VPN link for already subscribed users. If a user log into different machine other than the VPN purchased machine or app, Start free trial button is the only option in the widget to log into VPN (ofcourse toolbar VPN onboarding panel has the Already purchased Brave VPN link). Would be great to provide this link on the card widget as well.

Steps to reproduce

pre-requisite: subscribe to Brave VPN on a different machine or in the app

  1. Install 1.75.x
  2. launch Brave
  3. open NTP
  4. observe Brave VPN card widget

Actual result

Already purchased Brave VPN? link is not available

Image

Expected result

Already purchased Brave VPN? link should be available for existing Brave VPN users

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.75.55 Chromium: 131.0.6778.85 (Official Build) nightly (64-bit)
-- | --
Revision | 3cc3ba11608e3bbbf9e053bdd032ec05e2a4db7f
OS | Windows 11 Version 24H2 (Build 26100.2314)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@mattmcalister @bsclifton
cc: @rebron @brave/qa-team

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 3, 2024
@kleantzogu
Copy link

Updated the CTA copy and the "Already purchased Brave VPN?" link.

Image

Figma Link: https://www.figma.com/design/0JkrJVn9XyDM0yjjZ6XQy5/NTP-exploration?node-id=659-255156&t=PYEpHhcCbwisiKb1-4

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. release-notes/exclude and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 3, 2024
@simonhong
Copy link
Member

working on this.

@kjozwiak
Copy link
Member

kjozwiak commented Dec 6, 2024

The above requires 1.73.99 or higher for 1.73.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 6, 2024
@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.73.99 Chromium: 131.0.6778.108 (Official Build) (64-bit)
-- | --
Revision | 273b36438521dd91cbab7a047e6d90deabf59d56
OS | Windows 10 Version 22H2 (Build 19045.5131)
  • Verified the STR from the description and test plan from Added recover link to vpn card widget brave-core#26853
  • Confirmed that the VPN card has Already purchased Brave VPN? link at the bottom
  • Confirmed that click on Already purchased Brave VPN? link redirects to https://account.brave.com/?intent=recover&product=vpn
Example Example
Image Image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants