Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing and reopening browser with full screen chat window hides the side navigation #42610

Open
2 of 6 tasks
srirambv opened this issue Dec 2, 2024 · 4 comments
Open
2 of 6 tasks

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2024

Description

Closing and reopening browser with full screen chat window hides the side navigation

Steps to reproduce

  1. Enable AIChatHistory flag
  2. Summarize a page in Leo
  3. Expand to open in full view
  4. Open a bunch of full view and add new conversations
  5. Quit and relaunch browser
  6. Full view Leo chat tabs don't have side navigation and missing history (Closing browser with active conversations in full view are lost after restart #42452)

Actual result

brave_traSwA7Jn0.mp4

Expected result

Should continue to show the side navigation when browser is restarted

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.74.15 Chromium: 131.0.6778.85 (Official Build) beta (64-bit)
Revision d1293587128488865fa61e9fa277dd54aa2270b0
OS Windows 11 Version 23H2 (Build 22631.4460)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @mattmcalister @petemill

@srirambv
Copy link
Contributor Author

srirambv commented Dec 2, 2024

This also creates problem with close button not working on the full view chat Image

@petemill
Copy link
Member

petemill commented Dec 2, 2024

This also creates problem with close button not working on the full view chat

This is not an issue in 1.75 where the features have landed. The fact that the side navigation is missing entirely in 1.74 on FullPage tabs that are loaded at browser startup is perhaps conflating the issue being reported?

@petemill
Copy link
Member

petemill commented Dec 2, 2024

I'm not sure that we intend this to be something that is remembered. The navigation with conversations list is contracted when there is not much space. Perhaps we want to remember on larger windows that the user minimizes the conversation list navigation? But on small screens it becomes floating. @aguscruiz

@aguscruiz
Copy link

In that video, it looks like the content of the full page version is being replaced with the sidebar version of Leo.

See how there's now a "history" section in the menu that shouldn't be there in full page, neither the option to navigate to the sidebar version of history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants