Warning user when disabling MV2 uBlock Origin

[ryanbr]

Description

If a user unselects uBO in brave://settings/extensions/v2 All filters and custom settings are removed.

Prompt the user with a warning will clear uBO data and settings.

Steps to reproduce

1. Unselect mv2 uBO (and probably other extensions will clear settings)

Actual result

Currently deletes all settings automatically.

Expected result

Warn user that unselecting will clear extension data

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Current Brave ver

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

ref: https://old.reddit.com/r/uBlockOrigin/comments/1h41myj/end_of_support_for_ubo_on_chrome_chromium/lzv1cmt/?context=3

Why is there no warning that disabling an extension there will REMOVE IT (wiping your config) instead of just disabling it so you can restore it later?

You should either add a warning or offer the user a choice to remove or disable it temporarily. A lot of people doesn't backup their extension settings regularly so having an option like that with no warnings seems like a terrible idea to me.

[ShivanKaul]

Instead of showing a warning, we can simply split the current "toggled off" state to be different between "disabled" and "uninstalled". When the user toggles the button on an extension in brave://settings/extensions/v2, we should "disable" first, and then show a button called Remove next to the toggle. Then we don't need a warning.

[u-RraaLL]

Yup, that's very close to what I meant with:

or offer the user a choice to remove or disable it temporarily