Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise 1 - Treasure Island movies question #54

Open
richardguinness opened this issue Jun 14, 2021 · 1 comment
Open

Exercise 1 - Treasure Island movies question #54

richardguinness opened this issue Jun 14, 2021 · 1 comment

Comments

@richardguinness
Copy link

Hi Brandon,

Thanks for an excellent tutorial.

Your answer to q "List all of the "Treasure Island" movies from earliest to most recent." is
titles[titles.title == 'Treasure Island'].sort_values('year')

There are a few Treasure Island movies (e.g. Treasure Island (II) ) which will not make it through this filter.

This could be addressed by changing the answer to the following:
titles[titles.title.str.startswith('Treasure Island')].sort_values('year')

Or perhaps the question is a little ambiguous.

All the best,

Richard

@brandon-rhodes
Copy link
Owner

Interesting! I hadn't considered multiple Treasure Islands released in the same year. It might be a while before I return to this repository to re-run its notebooks, but when I do, I'll see about getting the solution updated to something like what you recommend here. Thanks for suggesting this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants