Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It is not possible to add the same pokemon twice in a list #12

Open
brandizzi opened this issue Feb 17, 2021 · 0 comments
Open

It is not possible to add the same pokemon twice in a list #12

brandizzi opened this issue Feb 17, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@brandizzi
Copy link
Owner

It is not possible to add the same pokemon twice to a list.

Steps to reproduce

  1. Create a new comparison.
  2. Add "Pikachu" to the left list.
  3. Add "Pikachu" to the left list again.

Expected results

"Pikachu" would be listed twice.

Actual results

"Pikachu" is listed once.
@brandizzi brandizzi added the bug Something isn't working label Feb 17, 2021
brandizzi added a commit that referenced this issue Feb 17, 2021
@brandizzi
#12 Test demostranting we cannot add the same pokemon twice.
e54609f
brandizzi added a commit that referenced this issue Feb 17, 2021
@brandizzi
#12 Create an intermediate entity to be added to the comparison lists…
2aab613 
…, that can be repeated.
brandizzi added a commit that referenced this issue Feb 17, 2021
@brandizzi
#12 Create some properties and methods to abstract a bit the migratio…
1c12690 
…n between the old, direct lists and the new, mediated lists.
brandizzi added a commit that referenced this issue Feb 17, 2021
@brandizzi
#12 Use new mediated properties/method in tests.
ec321b9
brandizzi added a commit that referenced this issue Feb 17, 2021
@brandizzi
#12 Update views to use proper properties whenever needed.
15c7dff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandizzi