Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility fixes #56

Open
6 tasks
nfreear opened this issue Mar 31, 2021 · 1 comment
Open
6 tasks

Accessibility fixes #56

nfreear opened this issue Mar 31, 2021 · 1 comment

Comments

@nfreear
Copy link

nfreear commented Mar 31, 2021

Hi,

I'm identifying various Web accessibility (accessibility to those with disabilities).

I'd like to submit one or more fixes / pull requests for these — is this OK please?

Things that need fixing:

  • — Ensure all buttons (including those that use <div>) are given a role of 'button' — for screen reader/ non-visual users;
  • — Ensure all buttons can be navigated to and activated with the keyboard ('TAB', shift-TAB, Enter keys) — keyboard users, including screen reader/ non-visual users;
  • — Ensure all buttons have a suitable label/ name — non-visual users;
  • — Ensure the cookie-bar and cookie-modal have WAI-ARIA landmark regions, and labels;
  • — Ensure the cookie-modal behaves like proper modal (that is, links behind are inactive/ cannot be navigated to);
  • More ...?

A number of the above are fairly straightforward fixes.

I'll let you know how I get on.

Yours,

Nick


Translation of "Cookie notice" in Hungarian ?!

@DanielNelsonCantarus
Copy link

Hi Nick, our team are looking to use this module and have also noticed the lack of accessibility features, have you made any progress on addressing any of the tasks you've raised here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants