Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch 3.6 gives improper and lower quality segmentations in specific tracks #17

Open
bacaron opened this issue Jun 1, 2020 · 1 comment

Comments

@bacaron
Copy link
Contributor

bacaron commented Jun 1, 2020

Hey,

I've had previous runs of the segmentation app on branch 3.3 that generated overall great segmentations in most tracks, especially the uncinate and ILF (see screenshots). However, I have a few subjects missing ILFs, prompting need for further investigation and rerunning of the app.

I recently ran the latest version of the app this morning (branch 3.6), and although it returns both ILFs in a subject that had previously been missing them, it has now caused a reduction in quality of the ILF from the segmentation generated from branch 3.3 and the uncinate (see screenshots).

Comparing change logs, it appears there have been multiple updates to wma_tools but it's hard to gather what the specific changes in code are and how they would relate to the differences in segmentation.

Is it possible some old code might have snuck its way into the newest branch? Or did the new changes implemented since branch 3.3 lead to the observed differences in segmentations.

Happy to provide the data that generated both segmentations, and the segmentations themselves.

Thanks,
Brad

Branch 3.3 right uncinate: good
branch_3_3_right_uncinate_good

branch 3.6 right uncinate: not good
branch_3_6_right_uncinate_not_good

branch 3.3 right ilf: good
branch_3_3_right_ilf_good

branch 3.6 right ilf: not good
branch_3_6_right_ilf_not_good

@soichih
Copy link
Contributor

soichih commented Mar 5, 2021

@bacaron are you still seeing this problem on the latest version (3.8)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants