Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show fiber counts in logarithmic scale? #12

Open
soichih opened this issue Aug 12, 2019 · 6 comments
Open

Show fiber counts in logarithmic scale? #12

soichih opened this issue Aug 12, 2019 · 6 comments

Comments

@soichih
Copy link
Contributor

soichih commented Aug 12, 2019

I think we should show the fiber count in log scale?

image

To switch to log, all we need to do is to set the type field to "log" for plotlyjs

var layout = {
  xaxis: {
    type: 'log',
    autorange: true
  },
  yaxis: {
    type: 'log',
    autorange: true
  }
};

@DanNBullock
Copy link
Contributor

I'm not sure that would be consistent with the goals of this visualization. As I understand it this visualization is used to compare counts across subjects and tracts. By log scaling it, you wash out all of the visually perceptible variation. What would the goal of log-scaling be?

@soichih
Copy link
Contributor Author

soichih commented Aug 12, 2019

I don't know if there is a specific goal in mind for this visualization, but I'd argue that linear scaling is actually washing out the visually perceptible variation for tracts that has much small number of fibers (like IFOF).

By the way, another way to show this might be to actually multiply the length of the fibers with the count of fibers (call it the "fiber size"). Would it be interesting to show that?

@francopestilli
Copy link
Contributor

I like the idea of Log. Comparing across tracts currently is difficult because of the wide range in fiber number.

@DanNBullock
Copy link
Contributor

Fair enough about using a log scale, but that' isn't necessarily something that needs to be done on this end. Shouldn't you just be able to do that on the plot end? In fact, I'd say we don't even need to make a choice on this, you could just have a button on the interface that would logscale the y axis. Seems like it wouldn't be that hard to code.

Also, with respect to "By the way, another way to show this might be to actually multiply the length of the fibers with the count of fibers (call it the "fiber size"). Would it be interesting to show that?"

That's what I'd refer to as wiring cost or length. Its one of the included outputs of the quality check. I'd also argue that the quality check is something that we should be running standard on segmentation outputs.

@soichih
Copy link
Contributor Author

soichih commented Aug 12, 2019

plotlyjs currently doesn't provide the capability to switch between different scales.. but it might in the future..

We could still update it so that it will show in log scale by default. Right now we have to set it as part of generated plotlyjs json which is done in here > https://github.com/DanNBullock/wma_tools/blob/master/wma_formatForBrainLife_v2.m#L166

I think all you have to add is this

barlayout.xaxis.type = 'log';

@DanNBullock
Copy link
Contributor

Would that leave the over displays as the absolute count? If the hover display switches to log scale the visualization's utility will be greatly diminished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants