Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-replay: print response received #121

Open
righettod opened this issue Nov 14, 2020 · 4 comments
Open

grpc-replay: print response received #121

righettod opened this issue Nov 14, 2020 · 4 comments

Comments

@righettod
Copy link

Hello,

It is possible to add the capability in the tool to print the response received ?

Thanks a lot again for this toolkit 👍

@bradleyjkemp
Copy link
Owner

Hey 👋🏻

Would you mind expanding a bit on what you're looking to get out of this? (i.e. what benefit does printing the response give you?)
Just want to make sure there's not a more general enhancement we could make that could be even more useful 🙂

@righettod
Copy link
Author

righettod commented Nov 18, 2020

Hi,

In fact after having captured an echange with grpc-dump, I resent it via grpc-replay after having modified the message and I just need to see the response to this replay in order to see if my update has changed the behavior of the service.

I use grpc-replay to perform fuzzing against a service exposed via gRPC.

Feel free to indicate to me if I misuse the toolkit or if I have missed something 😃

@bradleyjkemp
Copy link
Owner

Ah I see, that's a very valid use of these tools! 🙂

I see that grpc-replay currently just prints "Err mismatch" if the service returns an unexpected response (https://github.com/bradleyjkemp/grpc-tools/blob/master/grpc-replay/replay/replay.go#L99). Seems completely reasonable to print out what the mismatch is at this point which should fulfill your needs?

I can't guarantee any timelines on adding this but it shouldn't be difficult once I get round to it

@righettod
Copy link
Author

Yes, take the time you need, it's a spare time project 😃

Thanks again for your feedback and this amazing toolikt 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants