From d66f0a75bc13a9c12beb5be91bf3f80b1e04ea29 Mon Sep 17 00:00:00 2001 From: Nico Rehwaldt Date: Fri, 6 Mar 2026 14:39:35 +0100 Subject: [PATCH 1/3] test: validate dual use of read and written variable --- test/fixtures/zeebe/read-write.bpmn | 45 ++++++++++++++ .../zeebe/read-write.hierarchical.bpmn | 45 ++++++++++++++ test/spec/zeebe/ZeebeVariableResolver.spec.js | 60 +++++++++++++++++++ 3 files changed, 150 insertions(+) create mode 100644 test/fixtures/zeebe/read-write.bpmn create mode 100644 test/fixtures/zeebe/read-write.hierarchical.bpmn diff --git a/test/fixtures/zeebe/read-write.bpmn b/test/fixtures/zeebe/read-write.bpmn new file mode 100644 index 0000000..74b2992 --- /dev/null +++ b/test/fixtures/zeebe/read-write.bpmn @@ -0,0 +1,45 @@ + + + + + + + + + + + + + Write: approved + + + + Read: approved + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/test/fixtures/zeebe/read-write.hierarchical.bpmn b/test/fixtures/zeebe/read-write.hierarchical.bpmn new file mode 100644 index 0000000..c574700 --- /dev/null +++ b/test/fixtures/zeebe/read-write.hierarchical.bpmn @@ -0,0 +1,45 @@ + + + + + + + + + + + + + Write: application.approved + + + + Read: application.approved + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/test/spec/zeebe/ZeebeVariableResolver.spec.js b/test/spec/zeebe/ZeebeVariableResolver.spec.js index f6e3536..4669e02 100644 --- a/test/spec/zeebe/ZeebeVariableResolver.spec.js +++ b/test/spec/zeebe/ZeebeVariableResolver.spec.js @@ -31,6 +31,8 @@ import subprocessNoOutputMappingXML from 'test/fixtures/zeebe/sub-process.no-out import longBrokenExpressionXML from 'test/fixtures/zeebe/long-broken-expression.bpmn'; import immediatelyBrokenExpressionXML from 'test/fixtures/zeebe/immediately-broken-expression.bpmn'; import typeResolutionXML from 'test/fixtures/zeebe/type-resolution.bpmn'; +import readWriteXML from 'test/fixtures/zeebe/read-write.bpmn'; +import readWriteHierarchicalXML from 'test/fixtures/zeebe/read-write.hierarchical.bpmn'; import VariableProvider from 'lib/VariableProvider'; import { getInputOutput } from '../../../lib/base/util/ExtensionElementsUtil'; @@ -2602,6 +2604,64 @@ describe('ZeebeVariableResolver', function() { }); + + describe('used variables - read and written', function() { + + beforeEach(bootstrapModeler(readWriteXML, { + additionalModules: [ + ZeebeVariableResolverModule + ], + moddleExtensions: { + zeebe: ZeebeModdle + } + })); + + + it('should indicate dual use', inject(async function(elementRegistry, variableResolver) { + + // given + const task = elementRegistry.get('ValidateApprovedTask'); + + // when + const variables = await variableResolver.getVariablesForElement(task); + + // then + expect(variables).to.variableEqual([ + { name: 'approved', scope: 'Process_1', origin: [ 'ValidateApprovedTask' ], usedBy: [ 'ValidateApprovedTask' ] } + ]); + })); + + }); + + + describe('used variables - read and written / hierarchical', function() { + + beforeEach(bootstrapModeler(readWriteHierarchicalXML, { + additionalModules: [ + ZeebeVariableResolverModule + ], + moddleExtensions: { + zeebe: ZeebeModdle + } + })); + + + it('should indicate dual use', inject(async function(elementRegistry, variableResolver) { + + // given + const task = elementRegistry.get('ValidateApprovedTask'); + + // when + const variables = await variableResolver.getVariablesForElement(task); + + // then + expect(variables).to.variableEqual([ + { name: 'application', scope: 'Process_1', origin: [ 'ValidateApprovedTask' ], usedBy: [ 'ValidateApprovedTask' ] } + ]); + })); + + }); + }); // helpers ////////////////////// From 5b75352adc060129efc245a7db39344a43aa057d Mon Sep 17 00:00:00 2001 From: Nico Rehwaldt Date: Fri, 6 Mar 2026 20:26:51 +0100 Subject: [PATCH 2/3] Update test/fixtures/zeebe/read-write.bpmn Co-authored-by: Simon --- test/fixtures/zeebe/read-write.bpmn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fixtures/zeebe/read-write.bpmn b/test/fixtures/zeebe/read-write.bpmn index 74b2992..6e7a31b 100644 --- a/test/fixtures/zeebe/read-write.bpmn +++ b/test/fixtures/zeebe/read-write.bpmn @@ -4,7 +4,7 @@ - + From fc6b6c4cff7a9cfe3da56bcbdb36a4be36f95820 Mon Sep 17 00:00:00 2001 From: Nico Rehwaldt Date: Fri, 6 Mar 2026 20:27:00 +0100 Subject: [PATCH 3/3] Update test/fixtures/zeebe/read-write.hierarchical.bpmn Co-authored-by: Simon --- test/fixtures/zeebe/read-write.hierarchical.bpmn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fixtures/zeebe/read-write.hierarchical.bpmn b/test/fixtures/zeebe/read-write.hierarchical.bpmn index c574700..586a784 100644 --- a/test/fixtures/zeebe/read-write.hierarchical.bpmn +++ b/test/fixtures/zeebe/read-write.hierarchical.bpmn @@ -4,7 +4,7 @@ - +