fix: use default value for cancelRemainingInstances for edit marker

fix: undo breaking change in peer dependencies

Related to #1149

Author: barmac

.github/workflows/CI.yml

@@ -8,7 +8,7 @@ jobs:
       matrix:
         integration: [ true ]
         integration-deps:
-        - [email protected] bpmn-js@18.6.3
+        - [email protected] bpmn-js@11.5
         - "@bpmn-io/properties-panel@3"
         include:
           - integration-deps: "" # as defined in package.json

CHANGELOG.md

@@ -6,6 +6,11 @@ All notable changes to [bpmn-js-properties-panel](https://github.com/bpmn-io/bpm
 
 ___Note:__ Yet to be released changes appear here._
 
+## 5.42.1
+
+* `FIX`: use default value for `cancelRemainingInstances` for edit marker
+* `FIX`: undo breaking change in peer dependencies ([#1149](https://github.com/bpmn-io/bpmn-js-properties-panel/issues/1149))
+
 ## 5.42.0
 
 * `FEAT`: support multiline feel strings in `camunda` dialect ([@bpmn-io/lezer-feel#2](https://github.com/bpmn-io/lezer-feel/pull/2))

package.json

@@ -109,7 +109,7 @@
   },
   "peerDependencies": {
     "@bpmn-io/properties-panel": ">= 3.7",
-    "bpmn-js": ">= 18.6.3",
+    "bpmn-js": ">= 11.5",
     "camunda-bpmn-js-behaviors": ">= 0.4",
     "diagram-js": ">= 11.9"
   }

src/provider/bpmn/properties/AdHocCompletionProps.js

@@ -2,9 +2,8 @@ import { is, getBusinessObject } from 'bpmn-js/lib/util/ModelUtil';
 
 import {
   CheckboxEntry,
-  isCheckboxEntryEdited,
   isTextFieldEntryEdited,
-  TextFieldEntry
+  TextFieldEntry,
 } from '@bpmn-io/properties-panel';
 
 import { useService } from '../../../hooks';
@@ -33,9 +32,8 @@ export function AdHocCompletionProps(props) {
     {
       id: 'cancelRemainingInstances',
       component: CancelRemainingInstances,
-
-      isEdited: isCheckboxEntryEdited
-    }
+      isEdited: (node) => node && !node.checked // the default value is true
+    },
   ];
 }
 

test/spec/provider/bpmn/AdHocCompletionProps.spec.js

@@ -204,11 +204,11 @@ describe('provider/bpmn - AdHocCompletion', function() {
 
     describe('#cancelRemainingInstances', function() {
 
-      it('should not be checked when not explicitely configured on the process', inject(async function(elementRegistry, selection) {
+      it('should be checked when not explicitely configured on the process', inject(async function(elementRegistry, selection) {
 
         // given
         const subprocess = elementRegistry.get('Subprocess_2');
-        expect(getCancelRemainingInstancesValue(subprocess)).not.to.exist;
+        expect(getCancelRemainingInstancesValue(subprocess)).to.be.true;
 
         // when
         await act(() => {
@@ -218,7 +218,7 @@ describe('provider/bpmn - AdHocCompletion', function() {
         // then
         const cancelRemainingInstancesCheckbox = getCancelRemainingInstancesCheckbox(container);
         expect(cancelRemainingInstancesCheckbox).to.exist;
-        expect(cancelRemainingInstancesCheckbox.checked).to.be.false;
+        expect(cancelRemainingInstancesCheckbox.checked).be.true;
       }));
 
 

test/spec/provider/zeebe/AdHocCompletionProps.spec.js

@@ -264,13 +264,13 @@ describe('provider/zeebe - AdHocCompletion', function() {
 
     describe('#cancelRemainingInstances', function() {
 
-      it('should not be checked when not explicitely configured on the process', inject(async function(
+      it('should be checked when not explicitely configured on the process', inject(async function(
           elementRegistry, selection
       ) {
 
         // given
         const subprocess = elementRegistry.get('Subprocess_2');
-        expect(getCancelRemainingInstancesValue(subprocess)).not.to.exist;
+        expect(getCancelRemainingInstancesValue(subprocess)).to.be.true;
 
         // when
         await act(() => {
@@ -280,7 +280,7 @@ describe('provider/zeebe - AdHocCompletion', function() {
         // then
         const cancelRemainingInstancesCheckbox = getCancelRemainingInstancesCheckbox(container);
         expect(cancelRemainingInstancesCheckbox).to.exist;
-        expect(cancelRemainingInstancesCheckbox.checked).to.be.false;
+        expect(cancelRemainingInstancesCheckbox.checked).be.true;
       }));