Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxmox_virtual_environment_file checksum - add support for SHA512 and/or others #1623

Open
piratecarrot opened this issue Nov 7, 2024 · 2 comments
Labels
⌛ pending author's response Requested additional information from the reporter ✨ enhancement New feature or request

Comments

@piratecarrot
Copy link

piratecarrot commented Nov 7, 2024

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
When getting specific resources from online sources, such as the Debian cloud images, they provide only SHA512 checksums.

Arch Linux with its PKGBUILD system has something similar where one or more different checksums of varying algorithms can be stated. https://wiki.archlinux.org/title/PKGBUILD Section 8 "Integrity".

I would like to see, checksum remain which defaults to SHA256 and porovides backward compatibility. In addition, add new optional fields:

  • sha512sum
  • b2sum
    and add more as they become requested or supported.

Describe alternatives you've considered
As a workaround I currently download the file locally, check the integrity using SHA512. If it passes, computer the SHA256 and use that within Terraform.

Additional context
N/A

@piratecarrot piratecarrot added the ✨ enhancement New feature or request label Nov 7, 2024
@piratecarrot
Copy link
Author

Didn't realise there was
proxmox_virtual_environment_download_file, which supports the checksum option.

Regardless, I created a proof of concept which seems to work well, for local files.
https://github.com/siyka-au/terraform-provider-proxmox/tree/issues/1623

I am very new to terraform so I am still learning the ropes on that front.

@bpg
Copy link
Owner

bpg commented Nov 23, 2024

Hey @piratecarrot 👋🏼

I think that's a good idea! Would you mind opening a PR from your fork, so we can collaborate of this?

Thanks for contributing to the project! ❤️

@bpg bpg added the ⌛ pending author's response Requested additional information from the reporter label Nov 26, 2024
@bpg bpg moved this to On-Hold in terraform-provider-proxmox Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌛ pending author's response Requested additional information from the reporter ✨ enhancement New feature or request
Projects
Status: ⏳ On-Hold
Development

No branches or pull requests

2 participants