-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer support #19
Comments
Hey @tgeorgel, thanks for the kind words. To be honest, a contributor added "type='wordpress-plugin'" in a previous PR (#17) and it's a feature I don't take advantage of, nor fully understand. That said, assuming you've chose the install path from the README, the error your getting might be because the required Sorry if that comes off as basic "composer" advice. I'm just hoping for an easy win! |
@tgeorgel @boxybird I think now the problem is that since it is marked as a "wordpress-plugin", it will be automatically moved to the plugins-folder which requires a user to run I guess you should remove the type declaration (again) in order to get this plugin moved into the vendors directory by default in order to make it work without any further steps. PLUS anyone who needs this plugin to be moved to the // composer.json created by roots/bedrock
"extra": {
"installer-paths": {
"web/app/mu-plugins/{$name}/": [
"type:wordpress-muplugin",
"advanced-custom-fields/advanced-custom-fields-pro",
"bostondv/acf-ninja-forms",
"wpackagist-plugin/timber-library",
"wpackagist-plugin/svg-support",
"mortensassi/acf-svg-icon",
"ooksanen/acf-focuspoint",
"vinkla/headache",
"wpackagist-plugin/svg-support"
],
"web/app/plugins/{$name}/": [
"type:wordpress-plugin",
"boxybird/inertia-wordpress" // <<--- here
],
"web/app/themes/{$name}/": ["type:wordpress-theme"]
},
"wordpress-install-dir": "web/wp"
}, |
Hi there, first of all thanks for your amazing work !
I've seen you added the type="wordpress-plugin" in the
composer.json
on master so we can use composer to get the plugin, that's cool !However, the plugin still expect use to run
composer install
inside the plugin :Any idea how to fix this ?
Thanks !
The text was updated successfully, but these errors were encountered: