Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cssbuilder.CSSBuilder has no field or method CreateVlist #6

Open
AlfredoRamos opened this issue Jun 30, 2024 · 3 comments
Open

cssbuilder.CSSBuilder has no field or method CreateVlist #6

AlfredoRamos opened this issue Jun 30, 2024 · 3 comments
Assignees

Comments

@AlfredoRamos
Copy link

AlfredoRamos commented Jun 30, 2024

Hi 👋

Thanks for your work on this library.

We've been using this for some time, however since the latest update we can't build our app anymore.

$ go build -o build/app .
# github.com/speedata/bagme/document
../../../go/pkg/mod/github.com/speedata/[email protected]/document/document.go:82:22: d.cssbuilder.CreateVlist undefined (type *cssbuilder.CSSBuilder has no field or method CreateVlist)

We detected this with golangci-lint after upgrading the library:

$ golangci-lint run
[REDACTED].go:25:2: could not import github.com/speedata/bagme/document (-: # github.com/speedata/bagme/document
../../../go/pkg/mod/github.com/speedata/[email protected]/document/document.go:82:22: d.cssbuilder.CreateVlist undefined (type *cssbuilder.CSSBuilder has no field or method CreateVlist)) (typecheck)                                                                               
        "github.com/speedata/bagme/document"
        ^

And looking in the commit history, it was removed in commit 53a959b.

Our setup:

  • Go 1.22.4 linux/amd64
  • github.com/speedata/bagme v0.0.0-20231122194752-d1948a8d651e
  • github.com/speedata/baseline-pdf v0.0.0-20240621111510-9e70fb550141
  • github.com/speedata/boxesandglue v0.0.0-20240621111718-e173db49977c
  • github.com/speedata/css/scanner v0.0.0-20201005071706-2ed32c3ce553
  • github.com/speedata/gofpdi v1.0.18
  • github.com/speedata/hyphenation v1.0.2
  • github.com/speedata/textlayout v0.0.0-20230827181055-b7ff752e85ae
@pgundlach pgundlach self-assigned this Jun 30, 2024
@pgundlach
Copy link
Contributor

I will push my local changes as soon as possible, probably on Monday, I have changed a lot and it might break things, but I will correct the mistakes...

@pgundlach
Copy link
Contributor

Thank you very much for the bug report!

@pgundlach
Copy link
Contributor

I have updated some packages, but there are still some loose ends. I will keep working on it the next days hopefully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants