MDL-29148 MNet - improved handling of a verification function return code

mudrd8mz · stronk7 · commit 54941685e3e8 · 2011-08-29T01:48:55.000+02:00
diff --git a/mnet/xmlrpc/client.php b/mnet/xmlrpc/client.php
@@ -295,7 +295,8 @@ function send($mnet_peer) {
 
         // ok, it's signed, but is it signed with the right certificate ?
         // do this *after* we check for an out of date key
-        if (!openssl_verify($this->xmlrpcresponse, base64_decode($sig_parser->signature), $mnet_peer->public_key)) {
+        $verified = openssl_verify($this->xmlrpcresponse, base64_decode($sig_parser->signature), $mnet_peer->public_key);
+        if ($verified != 1) {
             $this->error[] = 'Invalid signature';
         }
 

Original file line number	Diff line number	Diff line change
`@@ -295,7 +295,8 @@ function send($mnet_peer) {`
`295`	`295`
`296`	`296`	`// ok, it's signed, but is it signed with the right certificate ?`
`297`	`297`	`// do this after we check for an out of date key`
`298`		`- if (!openssl_verify($this->xmlrpcresponse, base64_decode($sig_parser->signature), $mnet_peer->public_key)) {`
	`298`	`+ $verified = openssl_verify($this->xmlrpcresponse, base64_decode($sig_parser->signature), $mnet_peer->public_key);`
	`299`	`+ if ($verified != 1) {`
`299`	`300`	`$this->error[] = 'Invalid signature';`
`300`	`301`	`}`
`301`	`302`